We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine.io-client/lib/socket.js
Lines 5 to 6 in 9c79ba6
How about replacing this two with just URL & URLSearchParams?
The text was updated successfully, but these errors were encountered:
That's a good remark, thanks! I think we would need to provide a polyfill for some browsers though:
Which makes this change less appealing. What do you think?
Related: #674
Sorry, something went wrong.
At least if they are available natively the polyfill would be GC'ed and wouldn't need to do a much JIT parsing
// README.md example // Required for IE 11 support globalThis.URL = globalThis.URL || require('url').URL globalThis.URLSearchParams = globalThis.URLSearchParams || require('url').URLSearchParams const engine = require('engine.io-client')
ppl could also use core-js or polyfill.io
i guess core-js is based on some browser usage config or something like that
No branches or pull requests
engine.io-client/lib/socket.js
Lines 5 to 6 in 9c79ba6
How about replacing this two with just URL & URLSearchParams?
The text was updated successfully, but these errors were encountered: