Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switching from usage to help documentation by default #943

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jan 7, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

The current snyk cli shows a usage.txt help file when no command is given. That usage.txt file points to executing snyk --help to get more information in the usage. This PR simplifies that and directly shows help

Where should the reviewer start?

Run snyk and see if the help.txt is displayed by default

How should this be manually tested?

Executing snyk, snyk --help should both display help.txt

Any background context you want to provide?

It's just an improvement, making it a little bit more user friendly.

What are the relevant tickets?

None. Encountered this on first usage, and wanted to fix it directly. Let me know if you need a github issue.

Screenshots

before
Screen Shot 2020-01-07 at 10 29 48
after
Screen Shot 2020-01-07 at 10 29 59

Additional questions

None

@lili2311 lili2311 requested a review from a team as a code owner January 7, 2020 10:28
@lili2311 lili2311 self-assigned this Jan 7, 2020
@ghost ghost requested review from gitphill and orsagie January 7, 2020 10:28
@lili2311 lili2311 force-pushed the jdewinne-help-vs-usage branch 2 times, most recently from b43520d to 336614c Compare January 7, 2020 10:49
@lili2311 lili2311 merged commit 20223cf into master Jan 7, 2020
@lili2311 lili2311 deleted the jdewinne-help-vs-usage branch January 7, 2020 16:52
@snyksec
Copy link

snyksec commented Jan 7, 2020

🎉 This PR is included in version 1.277.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants