feat: multi level auto detect #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
orsagie
force-pushed
the
feat/multi-level-auto-detect
branch
from
3354e14
to
73fc9a8
Compare
dkontorovskyy
force-pushed
the
feat/multi-level-auto-detect
branch
3 times, most recently
from
f8ea93e
to
e8061fa
Compare
lili2311
reviewed
Dec 30, 2019
lili2311
reviewed
Dec 30, 2019
lili2311
reviewed
Dec 30, 2019
dkontorovskyy
force-pushed
the
feat/multi-level-auto-detect
branch
from
e8061fa
to
60f62e3
Compare
lili2311
reviewed
Dec 31, 2019
gitphill
force-pushed
the
feat/multi-level-auto-detect
branch
from
60f62e3
to
1730f83
Compare
lili2311
force-pushed
the
feat/multi-level-auto-detect
branch
from
1730f83
to
9927aa5
Compare
gitphill
force-pushed
the
feat/multi-level-auto-detect
branch
2 times, most recently
from
69ef728
to
2b971a6
Compare
lili2311
force-pushed
the
feat/multi-level-auto-detect
branch
from
56ec020
to
79d06b9
Compare
lili2311
reviewed
Jan 6, 2020
| @@ -26,9 +26,12 @@ export async function getMultiPluginResult( | |||
| const allResults: ScannedProjectCustom[] = []; | |||
| for (const targetFile of targetFiles) { | |||
| const optionsClone = _.cloneDeep(options); | |||
| optionsClone.file = path.basename(targetFile); | |||
| optionsClone.file = path.relative( | |||
There was a problem hiding this comment.
make targetFile relative to the root where the command was run
gitphill
force-pushed
the
feat/multi-level-auto-detect
branch
4 times, most recently
from
1ef861f
to
0d181b9
Compare
lili2311
force-pushed
the
feat/multi-level-auto-detect
branch
3 times, most recently
from
0189f2d
to
755d3d0
Compare
gitphill
force-pushed
the
feat/multi-level-auto-detect
branch
from
755d3d0
to
8b5ae16
Compare
gitphill
force-pushed
the
feat/multi-level-auto-detect
branch
from
4c7f48e
to
e302a5c
Compare
Add --detection-depth arg. Add tests for detection-depth arg to test and monitor. Ensure targetFile is not sent when plugin does not require it (retains project name on existing projects).
gitphill
force-pushed
the
feat/multi-level-auto-detect
branch
from
b47e644
to
5eccd37
Compare
|
🎉 This PR is included in version 1.275.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support to CLI to auto detect projects in multiple level deep folders.
Added --detection-depth CLI argument to support user supplied folder depth to search.
How should this be manually tested?
snyk test --all-projects --detection-depth=2
To detect all projects in current directory and one subfolder.
What are the relevant tickets?
BST-1118
Screenshots
snyk test test/acceptance/workspaces/large-mono-repo --all-projects --detection-depth=2
