feat: analytics include org #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ivanstanev
force-pushed
the
feat/analytics-include-org
branch
from
21ac3ba
to
810d6ed
Compare
Up until now the analytics payload that we send did not include the organisation specified as the --org parameter. While normal calls to `snyk test` resulted in the right org, analytics was saving data to the user's default organisation. This change now correctly collects the specified org so that the data is connected correctly.
Reported as warnings by ESLint, so clean them up.
ivanstanev
force-pushed
the
feat/analytics-include-org
branch
from
810d6ed
to
5e960a8
Compare
gitphill
approved these changes
Nov 29, 2019
|
🎉 This PR is included in version 1.254.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Up until now the analytics payload that we send did not include the organisation specified as the --org parameter.
While normal calls to
snyk testresulted in the right org, analytics was saving data to the user's default organisation.This change now correctly collects the specified org so that the data is connected correctly.
How should this be manually tested?
Run a local backend and point your snyk CLI there.
Set a breakpoint in
analytics.jsline 8 (to capture the/cliAPI call).Run
snyk test --org=<some org other than your preferred or default org>Notice the organisation is now the one specified by
--org!Any background context you want to provide?
Report in #boost-asks
What are the relevant tickets?
Jira ticket BST-425