feat: asynchronously process monitor args #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gitphill
commented
Nov 27, 2019
| const postingMonitorSpinnerLabel = | ||
| 'Posting monitor snapshot for ' + displayPath + ' ...'; | ||
|
|
||
| await spinner(analyzingDepsSpinnerLabel); |
There was a problem hiding this comment.
not sure about these spinners anymore? copied from existing, but since this is now done asynchronously the spinner can flicker as other jobs kick in
There was a problem hiding this comment.
can we start a spinner around this asyncMonitor? and update it as we start more jobs?
There was a problem hiding this comment.
I think it's ok for now, does indicate what's currently happening
gitphill
force-pushed
the
feat/parallelize-monitor
branch
from
bafabd0
to
d2a5484
Compare
Use Promise.all on each path passed to monitor. Added test for monitor using multiple paths.
gitphill
force-pushed
the
feat/parallelize-monitor
branch
from
d2a5484
to
22629c9
Compare
orsagie
approved these changes
Nov 28, 2019
|
🎉 This PR is included in version 1.252.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ivanstanev
added a commit
that referenced
this pull request
Dec 3, 2019
ivanstanev
added a commit
that referenced
this pull request
Dec 3, 2019
feat: Revert "Merge pull request #884 from snyk/feat/parallelize-monitor"
This was referenced Dec 11, 2019
Closed
Merged
Closed
Closed
This was referenced Dec 19, 2019
Closed
Closed
Closed
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use Promise.all on each path passed to monitor.
Added test for monitor using multiple paths.
How should this be manually tested?
Run 'snyk monitor ./path1 ./path2 ./path3 ...'
Use DEBUG=* to see each path is now processed asynchronously.
Any background context you want to provide?
In preparation for auto detect --all-projects feature.
What are the relevant tickets?
BST-1079