Refactor/tests #883
Merged
Refactor/tests #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
orsagie
force-pushed
the
refactor/tests
branch
2 times, most recently
from
d770956
to
a3c64f9
Compare
|
Maybe move |
orsagie
force-pushed
the
refactor/tests
branch
3 times, most recently
from
029ba0d
to
6b084c5
Compare
orsagie
force-pushed
the
refactor/tests
branch
2 times, most recently
from
df75772
to
db9eaf9
Compare
orsagie
commented
Nov 27, 2019
| @@ -1373,154 +1351,6 @@ test('`wizard` for unsupported package managers', async (t) => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('`protect` for unsupported package managers', async (t) => { | |||
There was a problem hiding this comment.
These tests are already in cli-protect.test.ts
orsagie
commented
Nov 27, 2019
| @@ -949,29 +950,6 @@ test('`monitor golang-app --file=vendor/vendor.json`', async (t) => { | |||
| ); | |||
| }); | |||
|
|
|||
| test('`test cocoapods-app (autodetect)`', async (t) => { | |||
orsagie
commented
Nov 27, 2019
| @@ -1535,51 +1365,6 @@ function stubExec(t, execOutputFile) { | |||
| }); | |||
| } | |||
|
|
|||
| test('error 401 handling', async (t) => { | |||
There was a problem hiding this comment.
These are already in cli-test tests
| const after = tap.runOnly ? only : test; | ||
|
|
||
| // Should be after `process.env` setup. | ||
| import * as plugins from '../../../src/lib/plugins/index'; |
There was a problem hiding this comment.
It's a nit peak, nothing more. Cos import will by default import index file. You can remove all the index occurrences
dkontorovskyy
approved these changes
Nov 27, 2019
orsagie
force-pushed
the
refactor/tests
branch
2 times, most recently
from
35a15d3
to
cd6d0fb
Compare
orsagie
force-pushed
the
refactor/tests
branch
from
cd6d0fb
to
b7ea65c
Compare
|
🎉 This PR is included in version 1.252.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor of tests