fix: adds back update functionality on npm versions of release #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gitphill
reviewed
Nov 4, 2019
| { | ||
| "//": "removes the file we use to identify a build as a standalone binary", | ||
| "path": "@semantic-release/exec", | ||
| "cmd": "rm dist/STANDALONE" |
There was a problem hiding this comment.
rm -f or do we want to fail if it doesn't exist?
There was a problem hiding this comment.
I would prefer for it to fail in this instance
thisislawatts
force-pushed
the
fix/update-blocker-on-npm-final
branch
from
56fae69
to
530e73c
Compare
lili2311
approved these changes
Nov 5, 2019
|
🎉 This PR is included in version 1.242.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following on from other PR which validates this flow within our CI this makes the actual change.
#854