Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update blocker on npm #854

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

thisislawatts
Copy link
Member

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fixes an issue where our semantic release build pipeline includes a file intended only for the standalone binary.

It appears that our semantic release process is adding STANDALONE to all builds of our CLI, not only those intended to be used by pkg.

How should this be manually tested?

Run a deployment of the CLI

@thisislawatts thisislawatts requested a review from a team as a code owner November 4, 2019 16:02
@thisislawatts thisislawatts self-assigned this Nov 4, 2019
@ghost ghost requested review from gitphill and lili2311 November 4, 2019 16:03
@CLAassistant
Copy link

CLAassistant commented Nov 4, 2019

CLA assistant check
All committers have signed the CLA.

@thisislawatts thisislawatts force-pushed the fix/update-blocker-on-npm branch 2 times, most recently from 24fdbbd to c248dd5 Compare November 4, 2019 17:01
@thisislawatts thisislawatts merged commit baa40cd into master Nov 5, 2019
@thisislawatts thisislawatts deleted the fix/update-blocker-on-npm branch November 5, 2019 05:56
@snyksec
Copy link

snyksec commented Nov 5, 2019

🎉 This PR is included in version 1.242.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants