Feat/node 6 deprecation warning #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
dkontorovskyy
force-pushed
the
feat/node-6-deprecation-warning
branch
2 times, most recently
from
d45f240
to
4ba347e
Compare
dkontorovskyy
force-pushed
the
feat/node-6-deprecation-warning
branch
2 times, most recently
from
2a0911e
to
5d7b30b
Compare
|
@dkontorovskyy looks good locally, please run the copy by Rachel? |
|
@lili2311 just to verify text with her? Or show how it actually looks ? |
dkontorovskyy
force-pushed
the
feat/node-6-deprecation-warning
branch
from
5d7b30b
to
12eab1a
Compare
|
@dkontorovskyy just to check the text yep! |
|
@lili2311 done! Do you want to approve ? |
lili2311
approved these changes
Nov 5, 2019
|
🎉 This PR is included in version 1.243.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an EOL warning at the end of the CLI output for users that are still using Node v6.
From external contribution #803
https://github.com/snyk/snyk/issues/787