Refactor: monitor to tidy & use more functions for readability and maintanability #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lili2311
changed the title
lili2311
commented
Nov 1, 2019
| @@ -1,6 +1,5 @@ | |||
| import * as _ from 'lodash'; | |||
| import chalk from 'chalk'; | |||
| import * as wrap from 'wrap-ansi'; | |||
lili2311
commented
Nov 1, 2019
| @@ -9,7 +8,6 @@ import { | |||
| GroupedVuln, | |||
| AnnotatedIssue, | |||
| DockerIssue, | |||
| LegalInstruction, | |||
lili2311
commented
Nov 1, 2019
| package: scannedProject.depTree, | ||
| }), | ||
| ); | ||
| perProjectResult = convertMultiPluginResultToSingle(inspectResult); |
There was a problem hiding this comment.
extracted code into a function
lili2311
commented
Nov 1, 2019
| @@ -218,7 +201,7 @@ async function monitor(...args0: MethodArgs): Promise<any> { | |||
| manageUrl, | |||
| options, | |||
| projectName, | |||
| advertiseSubprojectsCount, | |||
| foundProjectCount, | |||
lili2311
commented
Nov 1, 2019
lili2311
commented
Nov 1, 2019
| '"' + path + '" is not a valid path for "snyk monitor"', | ||
| ); | ||
| } | ||
| await validateMonitorPath(path, options.docker); |
There was a problem hiding this comment.
extracted code into a function
lili2311
commented
Nov 1, 2019
| advertiseSubprojectsCount = | ||
| inspectResult.plugin.meta.allSubProjectNames.length; | ||
| } | ||
| foundProjectCount = getSubProjectCount(inspectResult); |
There was a problem hiding this comment.
extracted code into a function
orsagie
reviewed
Nov 4, 2019
lili2311
force-pushed
the
refactor/monitor
branch
from
853f034
to
782d4a7
Compare
orsagie
approved these changes
Nov 4, 2019
lili2311
force-pushed
the
refactor/monitor
branch
from
782d4a7
to
5dccb99
Compare
|
🎉 This PR is included in version 1.242.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor to use more functions for easier to read & understand code
Added more types