chore: refactor pin remediation data structure #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Please change this to |
gitphill
force-pushed
the
chore/refactor-remediation-types
branch
from
3e8e4b4
to
31a3879
Compare
|
Please update the test fixture called |
lili2311
requested changes
Oct 28, 2019
|
Works ok locally |
lili2311
approved these changes
Oct 28, 2019
lili2311
force-pushed
the
chore/refactor-remediation-types
branch
2 times, most recently
from
49f5330
to
6891589
Compare
lili2311
reviewed
Oct 28, 2019
package.json
Outdated
| @@ -122,9 +123,6 @@ | |||
| "tslint": "^5.14.0", | |||
| "typescript": "^3.4.1" | |||
| }, | |||
| "bundledDependencies": [ | |||
There was a problem hiding this comment.
please rebase over latest master?
There was a problem hiding this comment.
This was removed a few days ago
gitphill
force-pushed
the
chore/refactor-remediation-types
branch
4 times, most recently
from
7292b74
to
25533ea
Compare
Align Pin and Upgrade data structures, using 'vuln' instead of 'issues'.
gitphill
force-pushed
the
chore/refactor-remediation-types
branch
from
25533ea
to
7670c92
Compare
|
🎉 This PR is included in version 1.239.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor PinRemediation datastructure to align with UpgradeRemediation, chaning 'issues' to 'vulns'.