fix: add pinning advice back to legacy formatter #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lwywoo
force-pushed
the
fix/re-add-pinning-advice
branch
from
3f9756a
to
016bbcc
Compare
test/acceptance/workspaces/pip-app-transitive-vuln/cli-output.txt
Outdated
Show resolved
Hide resolved
lwywoo
force-pushed
the
fix/re-add-pinning-advice
branch
2 times, most recently
from
77c12d6
to
5c8ca24
Compare
lili2311
reviewed
Oct 23, 2019
lili2311
reviewed
Oct 23, 2019
lili2311
reviewed
Oct 23, 2019
| Remediation: | ||
| Upgrade direct dependency flask@0.12.2 to flask@0.12.2 (triggers upgrades to flask@0.12.2) | ||
| Remediation: | ||
| Pin the transitive dependency Jinja2 to version 2.10.1 |
There was a problem hiding this comment.
this is a super weird fixture we never used to have remediation for python :|
lili2311
reviewed
Oct 23, 2019
| @@ -324,4 +324,4 @@ | |||
| "org": "kyegupov" | |||
lwywoo
force-pushed
the
fix/re-add-pinning-advice
branch
from
5c8ca24
to
11041c8
Compare
lwywoo
force-pushed
the
fix/re-add-pinning-advice
branch
from
11041c8
to
8268159
Compare
|
@lwywoo @robcresswell what is left to do here? |
|
@lili2311 Nothing, I've just been swamped with other high priority things. |
robcresswell
approved these changes
Nov 4, 2019
lili2311
approved these changes
Nov 4, 2019
|
🎉 This PR is included in version 1.242.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding the pinning advice back to the legacy formatter for python projects.
Without the
actionableCliRemediationflag and onlypythonPinningAdviceflag: