Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort all vulns by severity before display #742

Merged
merged 1 commit into from Aug 27, 2019

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Aug 21, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Sort vulns output for actionable remediation view.

Screen Shot 2019-08-21 at 15 49 56

@lili2311 lili2311 added the 🚧 WIP Work In Progress label Aug 21, 2019
@lili2311 lili2311 requested a review from a team as a code owner August 21, 2019 14:52
@lili2311 lili2311 self-assigned this Aug 21, 2019
@ghost ghost requested review from lwywoo and miiila August 21, 2019 14:52
@lili2311 lili2311 removed the 🚧 WIP Work In Progress label Aug 22, 2019
@lili2311 lili2311 force-pushed the feat/sort-actionable-remediation branch from 44d1584 to 42ec296 Compare August 22, 2019 09:00
@@ -56,6 +57,10 @@ export function formatIssuesWithRemediation(
return results;
}

export function getSeverityValue(severity) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types please :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@@ -56,6 +57,10 @@ export function formatIssuesWithRemediation(
return results;
}

export function getSeverityValue(severity) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types please :-)

@lili2311 lili2311 force-pushed the feat/sort-actionable-remediation branch from 42ec296 to ac9ba71 Compare August 23, 2019 14:02
@lili2311 lili2311 force-pushed the feat/sort-actionable-remediation branch from ac9ba71 to b741f66 Compare August 23, 2019 14:55
@lili2311
Copy link
Contributor Author

@miiila please re-check on Monday ty!

@lili2311 lili2311 merged commit 375b4d0 into master Aug 27, 2019
@lili2311 lili2311 deleted the feat/sort-actionable-remediation branch August 27, 2019 08:05
@snyksec
Copy link

snyksec commented Aug 27, 2019

🎉 This PR is included in version 1.221.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants