Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop unused "scenario" command #735

Merged
merged 1 commit into from
Aug 20, 2019
Merged

fix: drop unused "scenario" command #735

merged 1 commit into from
Aug 20, 2019

Conversation

kyegupov
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Drops "scenario" command which was supposed to be used to emulate complex tests, but was never actually used in practice.

Introduces a far more useful "woof" command instead.

@kyegupov kyegupov requested a review from a team as a code owner August 16, 2019 13:00
@kyegupov kyegupov self-assigned this Aug 16, 2019
@ghost ghost requested review from lwywoo and miiila August 16, 2019 13:00
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyegupov kyegupov merged commit d8e3b43 into master Aug 20, 2019
@kyegupov kyegupov deleted the chore/drop-scenario branch August 20, 2019 11:28
@snyksec
Copy link

snyksec commented Aug 20, 2019

🎉 This PR is included in version 1.217.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants