fix: reinstate --all-sub-project support for Gradle #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
kyegupov
force-pushed
the
fix/all-sub-projects
branch
from
27ecb30
to
04d2be3
Compare
orsagie
reviewed
Aug 13, 2019
src/lib/snyk-test/run-test.ts
Outdated
| }; | ||
| } else { | ||
| // We are using "options" to store some information returned from plugin that we need to use later, | ||
| // but don't want to send to Registry in the Payload. | ||
| // TODO(kyegupov): decouple inspect and payload so that we don't need this hack | ||
| options.subProjectNames = inspectRes.depRoots.map((depRoot) => depRoot.depTree.name); | ||
| options.subProjectNames = inspectRes.scannedProjects.map((depRoot) => depRoot.depTree.name); |
There was a problem hiding this comment.
Change to scannedProject variable name
There was a problem hiding this comment.
Renamed (+ all mentions of "depRoot" ever)
src/lib/snyk-test/run-test.ts
Outdated
| @@ -263,7 +262,7 @@ async function assembleLocalPayloads(root, options: Options & TestOptions): Prom | |||
| const deps = await getDepsFromPlugin(root, options); | |||
| analytics.add('pluginName', deps.plugin.name); | |||
|
|
|||
| for (const depRoot of deps.depRoots) { | |||
| for (const depRoot of deps.scannedProjects) { | |||
| @@ -632,7 +632,7 @@ test('`test gradle-app --all-sub-projects` returns correct multi tree meta', asy | |||
| async inspect() { | |||
There was a problem hiding this comment.
Maybe add the return type here, so we know it's the right one we are building?
kyegupov
force-pushed
the
fix/all-sub-projects
branch
from
04d2be3
to
2a0b445
Compare
orsagie
approved these changes
Aug 13, 2019
kyegupov
force-pushed
the
fix/all-sub-projects
branch
from
2a0b445
to
2c5533a
Compare
kyegupov
force-pushed
the
fix/all-sub-projects
branch
from
2c5533a
to
047998e
Compare
|
🎉 This PR is included in version 1.216.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
This was referenced Jul 9, 2020
This was referenced Aug 16, 2020
This was referenced Aug 27, 2020
This was referenced May 23, 2022
This was referenced Jul 27, 2022
This was referenced Sep 25, 2022
This was referenced Sep 30, 2022
This was referenced Feb 19, 2023
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
--all-sub-projectflag broken by the Gradle plugin upgrade.Also, fully use the plugin type definitions from the snyk-cli-interface package.