Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add legal instructions #726

Merged
merged 3 commits into from Aug 30, 2019
Merged

feat: add legal instructions #726

merged 3 commits into from Aug 30, 2019

Conversation

lwywoo
Copy link
Contributor

@lwywoo lwywoo commented Aug 9, 2019 •
edited

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Add legal instruction text to old and new formatters

What are the relevant tickets?

https://snyksec.atlassian.net/browse/BST-804

Screenshots

new formatter
Screenshot 2019-08-09 at 18 39 12
old formatter
Screenshot 2019-08-09 at 18 39 22

@lwywoo lwywoo requested a review from a team as a code owner August 9, 2019 17:00
@ghost ghost requested review from dkontorovskyy and orsagie August 9, 2019 17:00
@lili2311
Copy link
Contributor

lili2311 commented Aug 9, 2019

screenshot please :)

@lwywoo lwywoo force-pushed the feat/add_legal_instruction branch from 61c943f to 3ef902b Compare August 9, 2019 17:40
@lwywoo
Copy link
Contributor Author

lwywoo commented Aug 9, 2019

screenshot please :)

Adding, need to rebase in some changes ....

@lwywoo lwywoo force-pushed the feat/add_legal_instruction branch 3 times, most recently from d41041e to 5e4e3f2 Compare August 9, 2019 17:54
@lwywoo lwywoo self-assigned this Aug 9, 2019
dkontorovskyy
dkontorovskyy approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwywoo
Copy link
Contributor Author

lwywoo commented Aug 15, 2019 •
edited

Aligned text
Screenshot 2019-08-15 at 14 31 30
Screenshot 2019-08-15 at 14 31 41

@lwywoo lwywoo force-pushed the feat/add_legal_instruction branch 3 times, most recently from f138992 to fb82ebb Compare August 15, 2019 13:58
@lwywoo
Copy link
Contributor Author

lwywoo commented Aug 23, 2019 •
edited

Old formatter:
Screenshot 2019-08-23 at 11 58 25
New formatter
Screenshot 2019-08-23 at 11 41 42

@lwywoo lwywoo merged commit 63927b1 into master Aug 30, 2019
@lwywoo lwywoo deleted the feat/add_legal_instruction branch August 30, 2019 10:00
@snyksec
Copy link

snyksec commented Aug 30, 2019

🎉 This PR is included in version 1.222.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Jan 1, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Open
@EitanGayor EitanGayor mentioned this pull request Jun 30, 2022
Open
This was referenced Jul 27, 2022
Closed
Closed
@aliscco aliscco mentioned this pull request Aug 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2022
Open
This was referenced Sep 25, 2022
Open
Open
This was referenced Sep 30, 2022
Open
Open
@aliscco aliscco mentioned this pull request Oct 2, 2022
Open
@shaniHerz shaniHerz mentioned this pull request Oct 3, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2022
Open
This was referenced Feb 19, 2023
Merged
Merged
@cloudgeek7 cloudgeek7 mentioned this pull request Mar 15, 2023
Open
@darscan darscan mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 28, 2023
Open
Open
@darscan darscan mentioned this pull request Dec 1, 2023
Open
@robin-qualityengineer robin-qualityengineer mentioned this pull request Dec 19, 2023
Open
@AliADDOU AliADDOU mentioned this pull request Dec 20, 2023
Open
@darscan darscan mentioned this pull request Dec 20, 2023
Open
@darscan darscan mentioned this pull request Mar 22, 2024
Open
@robin-qualityengineer robin-qualityengineer mentioned this pull request Mar 22, 2024
Open
@AliADDOU AliADDOU mentioned this pull request Mar 22, 2024
Open
@darscan darscan mentioned this pull request Apr 15, 2024
Open
@AliADDOU AliADDOU mentioned this pull request Apr 15, 2024
Open
@romathur romathur mentioned this pull request Apr 16, 2024
Open
@RyanPHigh RyanPHigh mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lili2311 lili2311 lili2311 left review comments

@dkontorovskyy dkontorovskyy dkontorovskyy approved these changes

@orsagie orsagie Awaiting requested review from orsagie

Assignees

@lwywoo lwywoo

Labels
released
Projects
None yet
Milestone
No milestone
4 participants
@lwywoo @lili2311 @snyksec @dkontorovskyy