fix: handle dependency cycles in Gradle projects #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FauxFaux
approved these changes
Apr 16, 2019
|
Kicking flaky Travis build |
|
Kicking broken appveyor build |
|
🎉 This PR is included in version 1.151.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where parsing of the Gradle project with cyclic deps fails with StackOverflowError.
This also picks up changes introduced in gradle plugin version 2.7.0, but they should not affect anything (a new field with trivially generated data was added to the output, this field is unused so far).
What are the relevant tickets?
https://snyksec.atlassian.net/browse/BST-575