Merge internal and external (user defined) no_proxy #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve logging * cleanup unused utils * update application framework * update snyk-docker-plugin
PeterSchafer
force-pushed
the
fix/HMMR-627_restore_system_proxy
branch
from
6d15163
to
e92b1ae
Compare
Avishagp
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
internal/cliv2/cliv2.go
How should this be manually tested?
2022/12/28 15:52:31.349900 legacycli:1 - NO_PROXY = localhost,127.0.0.1,::1,googleapis.com,somethingelse
Any background context you want to provide?
For example when running remote docker in circleci, the external NO_PROXY configuration ensures that no traffic is being routed through any proxy.