fix: align tmp and cache dir #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avishagp
approved these changes
Dec 22, 2022
PeterSchafer
force-pushed
the
fix/HMMR-626
branch
5 times, most recently
from
e72e1d1
to
6abf792
Compare
PeterSchafer
force-pushed
the
fix/HMMR-626
branch
from
6abf792
to
ef6b69b
Compare
PeterSchafer
changed the title
|
Pair Reviewed with @asaf92 after doing additional changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid file system conflicts on linux and align where the CLI stores files on the local system.
Background
On linux, temp dir resolves to /tmp and we extended it to /tmp/snyk. If any user chose to use create a folder or file with the same name, there is a conflict.