Integrate support of NODE_EXTRA_CA_CERTS #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
force-pushed
the
fix/HMMR-610_extra_cert
branch
3 times, most recently
from
ed40344
to
792999c
Compare
PeterSchafer
requested review from
jonathansantilli,
robh-snyk and
alexandru-dragomir
PeterSchafer
force-pushed
the
fix/HMMR-610_extra_cert
branch
9 times, most recently
from
704e06a
to
e5c3640
Compare
Avishagp
reviewed
Dec 16, 2022
Avishagp
approved these changes
Dec 16, 2022
* forwarding externally defined NODE_EXTRA_CA_CERTS * internally using NODE_EXTRA_CA_CERTS Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com>
PeterSchafer
force-pushed
the
fix/HMMR-610_extra_cert
branch
from
e5c3640
to
8e69f00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If a user specifies additional root CAs via the environment variable NODE_EXTRA_CA_CERTS, they get added to the internal Certificate Pool and forwarded to child processes.
Also Golang is updated to 1.19.4 for building and throughout the CI pipeline.
Where should the reviewer start?
How should this be manually tested?
Run and look at "test/jest/acceptance/extra-certs.spec.ts"
Any background context you want to provide?
The Golang CLI uses NODE_EXTRA_CA_CERTS itself to set temporary certificates for child processes. If there are user defined certificates they need to be merged.