Integrate local sbom extension #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
requested review from
agatakrajewska,
jonathansantilli,
danlucian and
magdziarek
PeterSchafer
changed the base branch from
master
to
chore/HMMR-604_add_proxyauth
PeterSchafer
changed the title
PeterSchafer
force-pushed
the
chore/HMMR-577_integrate_sbom
branch
from
4bfda38
to
179f55f
Compare
PeterSchafer
force-pushed
the
chore/HMMR-577_integrate_sbom
branch
from
179f55f
to
873d3c3
Compare
Avishagp
reviewed
Dec 9, 2022
Avishagp
reviewed
Dec 9, 2022
Avishagp
approved these changes
Dec 9, 2022
PeterSchafer
force-pushed
the
chore/HMMR-577_integrate_sbom
branch
2 times, most recently
from
b2dcde5
to
1a2da57
Compare
mcombuechen
approved these changes
Dec 13, 2022
francescomari
approved these changes
Dec 13, 2022
PeterSchafer
force-pushed
the
chore/HMMR-577_integrate_sbom
branch
2 times, most recently
from
779fb5c
to
bee666b
Compare
… upgrade application framework Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com>
PeterSchafer
force-pushed
the
chore/HMMR-577_integrate_sbom
branch
from
bee666b
to
b9b5c20
Compare
Avishagp
approved these changes
Dec 13, 2022
Avishagp
pushed a commit
that referenced
this pull request
Dec 15, 2022
Integrate local sbom extension
Avishagp
pushed a commit
that referenced
this pull request
Dec 15, 2022
Integrate local sbom extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It integrates sbom as a local extension and improves the general application behaviour around extensions.
In addition some tests required adaption in the sense that they were expecting a certain order of messages being send which has now changed a bit. They have been either adapted to focus on certain messages or to avoid sending new messages.
Where should the reviewer start?
As usual start in cmd/cliv2/main.go
How should this be manually tested?
snyk sbom --experimental