Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: wrap osName() in try-catch #4231

Merged
merged 1 commit into from Dec 5, 2022
Merged

chore: wrap osName() in try-catch #4231

merged 1 commit into from Dec 5, 2022

Conversation

PeterSchafer
Copy link
Contributor

Signed-off-by: Peter Schäfer 101886095+PeterSchafer@users.noreply.github.com

What does this PR do?

Add try-catch block around the usage of os-name which throws an exception on macOS Ventura.

@PeterSchafer
chore: wrap osName() in try-catch
ead1824 
Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com>
@PeterSchafer PeterSchafer requested review from a team as code owners December 5, 2022 09:24
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/analytics/getStandardData.ts
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against ead1824

@PeterSchafer PeterSchafer merged commit f6d7eb2 into master Dec 5, 2022
@PeterSchafer PeterSchafer deleted the chore/HMMR-614_analytics_exception_handling branch December 5, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avishagp Avishagp Avishagp approved these changes

@topaztee topaztee Awaiting requested review from topaztee topaztee was automatically assigned from snyk/snyk-open-source

@dagrest dagrest Awaiting requested review from dagrest dagrest was automatically assigned from snyk/snyk-open-source

@tonidevine1 tonidevine1 Awaiting requested review from tonidevine1 tonidevine1 was automatically assigned from snyk/snyk-open-source

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PeterSchafer @Avishagp