New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: yarn lock v2 support plus improvements #4222
feat: yarn lock v2 support plus improvements #4222
Conversation
86d9aa4
to
58b6a66
Compare
a08025b
to
a995edf
Compare
790aa24
to
056d456
Compare
45f01e4
to
55ffd29
Compare
9c481bd
to
6931061
Compare
6931061
to
38dbe8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: As you have added new logic and control flows, it would be important to add new tests for it. From the description, I would assume to find at least one additional acceptance test that uses a yarn v2 file. Unit tests would be great too.
This adds support for yarn.lock v2, that yaml-like format. This means initial support for yarn2 and yarn3 as at time of writing they use this version. Additionally support for depgraph for yarn lock v1 (Yarn1) has been added which should improve performance for these older projects.
38dbe8b
to
798abf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with @JamesPatrickGill, adding additional tests will be done in a separate task. Approving to unblock.
This adds support for yarn lock v2 to the CLI aswell as a heavier use of depgraphs.
It also carries some slight Yarn v1 changes through due to using an outdated nodejs parser in the CLI.