Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not check stderr output in IaC smoke tests #4043

Merged
merged 1 commit into from Oct 4, 2022
Merged

fix: do not check stderr output in IaC smoke tests #4043

merged 1 commit into from Oct 4, 2022

Conversation

francescomari
Copy link
Contributor

Remove the check on stderr, which might not be empty because of code outside of IaC's control, like alerts.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Messages
📖

You are modifying something in test/smoke directory, yet you are not on the branch starting with smoke/. You can prefix your branch with smoke/ and Smoke tests will trigger for this PR.

Generated by 🚫 dangerJS against 55cbba0

@francescomari francescomari marked this pull request as ready for review October 4, 2022 10:56
@francescomari francescomari requested a review from a team as a code owner October 4, 2022 10:56
@francescomari francescomari merged commit e9b88b9 into master Oct 4, 2022
@francescomari francescomari deleted the fix/iac-smoke-stderr branch October 4, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipapast ipapast ipapast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@francescomari @ipapast