Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create smoke tests for experimental IaC tests #3838

Merged
merged 1 commit into from Sep 21, 2022

Conversation

ofekatr
Copy link
Contributor

@ofekatr ofekatr commented Sep 12, 2022

What does this PR do?

  • Creates smoke tests for the experimental IaC test.
  • Creates a new Github Action to run these smoke tests every hour and for every PR with IaC files.

Notes for the reviewer

  • As of writing this, the IAC_SMOKE_TESTS_SNYK_TOKEN secret with the authentication token was yet to be added by team Hammer, so the tests still fail on the authentication step of the snyk iac test --experimental command.

Any background context you want to provide?

After CFG-2061: Spike options for testing/monitoring resources availability for the CLI , we ended up on agreeing that a smoke test which downloads the artefacts and runs an IaC scan will give us enough confidence that the reyling artefacts are available and scans are working.

  • Language of choice: Jest

  • CI of choice: Github Action

  • Note: Jest vs shellspec was a tie in the original spike, I reached out to Hammer to see if they have seen any benefits of using shellspec, and I think they just transferred them to shellspec for historic reasons. they are actually thinking of keeping one language and leaning to migrate them to jest for v2.

What are the relevant tickets?

@ofekatr ofekatr force-pushed the chore/create-iac-e2e-tests-cfg-2106 branch 30 times, most recently from 7b34004 to 9c9f26e Compare September 12, 2022 15:27
@ofekatr ofekatr force-pushed the chore/create-iac-e2e-tests-cfg-2106 branch 26 times, most recently from b2a8574 to 17a9483 Compare September 20, 2022 16:25
@ofekatr ofekatr force-pushed the chore/create-iac-e2e-tests-cfg-2106 branch from 17a9483 to 8890fb3 Compare September 20, 2022 16:28
@ofekatr ofekatr merged commit d856544 into master Sep 21, 2022
@ofekatr ofekatr deleted the chore/create-iac-e2e-tests-cfg-2106 branch September 21, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants