chore: handle GOOS alpine in Makefile #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
force-pushed
the
chore/cliv2_support_alpine
branch
2 times, most recently
from
a580cb4
to
aa94877
Compare
PeterSchafer
force-pushed
the
chore/cliv2_support_alpine
branch
from
67206b0
to
54e1b40
Compare
Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: add alpine build to workflow Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: run v2 jtest on alpine Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: add test alpine to workflow Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: disable usage of sudo Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: temporarily add libc dependency to enable running Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: add additional dependencies for running tests on alpine Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: remove docker and docker-compose from alpine tests without docker installed proxy tests will be skipped unfortunately running docker on alpine was causing more issues so this the attempt to skip these tests Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: use musl explictly to compile for alpine Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: remove glibc installation again Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: install maven for alpine tests Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: temporarily skip failing test Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: adapt step name Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com>
PeterSchafer
force-pushed
the
chore/cliv2_support_alpine
branch
from
c35cbfa
to
581ebb8
Compare
Avishagp
reviewed
Sep 1, 2022
Avishagp
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add handling of alpine builds to the Makefile. It introduces the possibility to run
make build GOOS=alpine GOARCH=amd64How does it work?
While for the golang cli this will actually result in a linux build, the bundled TS cli will have to be build explicitly for alpine.