Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add unmanaged service test call ff #3603

Merged
merged 1 commit into from Sep 20, 2022
Merged

feat: add unmanaged service test call ff #3603

merged 1 commit into from Sep 20, 2022

Conversation

dagrest
Copy link

@dagrest dagrest commented Aug 18, 2022

What does this PR do?

  • Implements Feature Flag to switch to a new polling function that uses a new Unmanaged Service APIs
  • Implements a new polling function that uses a new Unmanaged Service APIs

Where should the reviewer start?

Implementation begins in the following function: resolveAndTestFacts

How should this be manually tested?

Use the following options: test --unmanaged, do not forget to enable feature flag, current name is 'snykNewUnmanagedTest'

What are the relevant tickets?

@dagrest dagrest requested review from a team as code owners August 18, 2022 07:10
@danielroymoore danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from 695a7f7 to 87b7ab3 Compare September 13, 2022 15:05
dekelund
dekelund reviewed Sep 14, 2022
View reviewed changes
src/lib/polling/polling-test.ts
}
}
}
return JSON.parse(result.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we move this return into the try, and reduce number or variables, alternative use a const in the try-block.

@danielroymoore danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from 87b7ab3 to d065704 Compare September 16, 2022 13:25
@danielroymoore danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from d065704 to 1201f7c Compare September 16, 2022 14:46
@danielroymoore danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from 1201f7c to 55b6fbb Compare September 16, 2022 14:51
@dagrest dagrest merged commit a3f87ba into master Sep 20, 2022
@dagrest dagrest deleted the feat/add-unmanaged-service-test-call-ff branch September 20, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroymoore danielroymoore danielroymoore left review comments

@dekelund dekelund dekelund approved these changes

@Avishagp Avishagp Avishagp approved these changes

@dpp dpp Awaiting requested review from dpp dpp was automatically assigned from snyk/snyk-open-source

@admons admons Awaiting requested review from admons admons was automatically assigned from snyk/snyk-open-source

@julianpellasrice-snyk julianpellasrice-snyk Awaiting requested review from julianpellasrice-snyk julianpellasrice-snyk was automatically assigned from snyk/snyk-open-source

Assignees

@dekelund dekelund

@danielroymoore danielroymoore

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dagrest @dekelund @danielroymoore @Avishagp