-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display policy's exclude entries #3057
Conversation
d76a676
to
9418699
Compare
cc2685c
to
60eed28
Compare
60eed28
to
c189dc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can approve the change to the IaC fixture here, but wanted to make sure you're aware of the Snyk IaC functionality under the exclude
field that was introduced here #3018. It doesn't look from the description like we've tested what the output of this looks like?
These excluded fields are not file paths but cloud resources, so the text may need to be adapted.
c189dc8
to
c1561b3
Compare
In order to support also the iac-drift entries I updated the message that we use for printing out the items to something like Below is an example:
I also updated the tests to include the |
- include the 'exclude' rules on the demunge implementation - exclude might contain 2 categories/ids: global and code - the entries for exclude.global/code might be simple paths (strings) or objects (including metadata like reason, creation/expiration dates).
c1561b3
to
dee758c
Compare
What does this PR do?
global
andcode
exclude.global/code
might be simple paths (strings) or objects (including metadata like reason, creation/expiration dates).The changes on the policy library were done here: snyk/policy#70
Screenshots