fix: remove target.branch #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YairZ101
force-pushed
the
fix/target-branch
branch
from
c63bf4c
to
973207f
Compare
YairZ101
force-pushed
the
fix/target-branch
branch
3 times, most recently
from
16f29f3
to
66c8b2b
Compare
YairZ101
changed the title
YairZ101
force-pushed
the
fix/target-branch
branch
from
66c8b2b
to
810b6b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, when running a scan from a directory that is a part of a git repo we will save inside the
targetfiled the repo remote URL and branch.We are using the remote URL to get information for the contributing developers but we currently don't have any use for the branch.
In addition to that, a side affect of sending the branch inside the
targetis that it gets auto-assigned as thetarget-referencewhich is not the desired outcome.Due to all the reasons I mentioned above we've decided to remove the branch from the
target.How should this be manually tested?
iacCliShareResultsFF.snyk iac test --reportto test your IaC files.