fix: propagate argument to all modules #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse args as a first things, before other modules are required. That will allow others to pick arguments.
miiila
force-pushed
the
fix/parse-args-as-first-thing
branch
from
e5933b1
to
b68c688
Compare
anthogez
reviewed
May 4, 2021
There was a problem hiding this comment.
Small question... why we are not propagating this globalArgs also in?
https://github.com/snyk/snyk/blob/b68c6882c7a1703428c58c191718a1d72bbe84ab/src/cli/index.ts#L427
maxjeffos
approved these changes
May 4, 2021
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse args as a first things, before other modules are required.
That will allow others to pick arguments.