Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tf plan full scan flag support #1865

Merged
merged 1 commit into from May 4, 2021
Merged

Conversation

rontalx
Copy link
Contributor

@rontalx rontalx commented Apr 28, 2021

What does this PR do?

Adds a new flag that supports scanning the full state of a terraform plan (the default is scanning only the delta).

snyk iac test tfplan.json --scan=resource-changes --experimental
snyk iac test tfplan.json --scan=planned-values --experimental

Where should the reviewer start?

New flag:
src/cli/commands/test/iac-local-execution/types.ts
src/cli/commands/test/iac-local-execution/assert-iac-options-flag.ts

Updated control flow:
src/cli/commands/test/iac-local-execution/index.ts
src/cli/commands/test/iac-local-execution/file-parser.ts

Tests:
test/jest/unit/iac-unit-tests/assert-iac-options-flag.spec.ts
test/smoke/spec/iac/snyk_test_local_exec_spec.sh

Documentation:
help/commands-docs/iac.md

What are the relevant tickets?

https://snyksec.atlassian.net/browse/CC-819

Slack Threads:

https://snyk.slack.com/archives/CS61093QC/p1619695624205800
https://snyk.slack.com/archives/CMM9V3XPY/p1619611809119700

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2021

Messages
📖 You are modifying something in test/smoke directory, yet you are not on the branch starting with smoke/. You can prefix your branch with smoke/ and Smoke tests will trigger for this PR.

Generated by 🚫 dangerJS against 8800697

@rontalx rontalx force-pushed the feat/tf-plan-full-scan branch 4 times, most recently from 80ac041 to ef29a82 Compare May 2, 2021 14:13
@rontalx rontalx marked this pull request as ready for review May 2, 2021 14:23
@rontalx rontalx requested a review from a team May 2, 2021 14:23
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

Expected release notes (by @rontalx)

features:
tf plan full scan flag support (8800697)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@rontalx rontalx requested a review from teodora-sandu May 4, 2021 08:33
@rontalx rontalx merged commit c6d1329 into master May 4, 2021
@rontalx rontalx deleted the feat/tf-plan-full-scan branch May 4, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants