Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: pipfile handler check & share common functionality #1835

Merged
merged 5 commits into from
Apr 16, 2021
Merged

Feat: pipfile handler check & share common functionality #1835

merged 5 commits into from
Apr 16, 2021

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Apr 16, 2021 •
edited

What does this PR do?

  • drop micromatch it was under used and not needed, the check is much simpler here as CLI already had done the work of classifying the project type as python.
  • add a new check with tests for a project that has a Pipfile manifest + tests (nothing is using it yet)

@lili2311 lili2311 self-assigned this Apr 16, 2021
@lili2311 lili2311 requested a review from a team as a code owner April 16, 2021 15:38
@lili2311 lili2311 changed the title Feat/pipfile handler check Feat: pipfile handler check & share common functionality Apr 16, 2021
aarlaud
aarlaud reviewed Apr 16, 2021
View reviewed changes
packages/snyk-fix/src/plugins/python/handlers/valdidate-required-data.ts
@@ -0,0 +1,26 @@
import { MissingRemediationDataError } from '../../../lib/errors/missing-remediation-data';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in filename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which one is the typo? Not quite sure

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2021 •
edited by lili2311

Expected release notes (by @lili2311)

fixes:
bail early if no fixable projects (1dfad93)

others (will not be included in Semantic-Release notes):
drop unused type (9d51308)
move isSupported and getRequiredData for sharing (84b314f)
check if targetFile is a Pipfile (69c6f81)
simplify requirements.txt check (89afd4a)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@lili2311 lili2311 merged commit 81563b2 into master Apr 16, 2021
@lili2311 lili2311 deleted the feat/pipfile-handler-check branch April 16, 2021 16:36
@snyk-bot snyk-bot mentioned this pull request Mar 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarlaud aarlaud aarlaud approved these changes

Assignees

@lili2311 lili2311

Labels
🐂 Team Bull
Projects
None yet
Milestone
No milestone
2 participants
@lili2311 @aarlaud