Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tests #1661

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Cleanup tests #1661

merged 2 commits into from
Feb 26, 2021

Conversation

maxjeffos
Copy link
Contributor

@maxjeffos maxjeffos commented Feb 26, 2021

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • Fixes timeout issue in test/dev-count-analysis.spec.ts
  • Remove tests that we migrated to Jest
  • Remove redundant test file

Any background context you want to provide?

https://app.circleci.com/pipelines/github/snyk/snyk/3839/workflows/2c632042-db4b-4790-993c-f298407ec5c0/jobs/22035

@maxjeffos maxjeffos requested review from a team as code owners February 26, 2021 14:27
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2021

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 02c99b8

@maxjeffos maxjeffos force-pushed the test/fix-flake-with-dev-count-analysis branch 4 times, most recently from 33bce44 to e4594c1 Compare February 26, 2021 16:31
@maxjeffos maxjeffos changed the title Set timeout in beforeAll Cleanup tests Feb 26, 2021
@maxjeffos maxjeffos force-pushed the test/fix-flake-with-dev-count-analysis branch 2 times, most recently from c765b60 to 8436237 Compare February 26, 2021 17:30
@maxjeffos maxjeffos force-pushed the test/fix-flake-with-dev-count-analysis branch from 8436237 to 02c99b8 Compare February 26, 2021 17:55
@maxjeffos maxjeffos merged commit 7dfd3ea into master Feb 26, 2021
@maxjeffos maxjeffos deleted the test/fix-flake-with-dev-count-analysis branch February 26, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant