test: convert flaky tests to jest & increase timeout #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
commented
Feb 23, 2021
test/monitor-target.spec.ts
Outdated
| async function getFakeServerRequestBody(server) { | ||
| const dir = path.join(__dirname, '/acceptance', 'workspaces'); | ||
| process.chdir(dir); | ||
| await cli.monitor('yarn-package'); |
There was a problem hiding this comment.
don't scan the root package as it triggers a super slow node_modules traversal test
lili2311
commented
Feb 23, 2021
| throw err; | ||
| } | ||
| // give file a little time to be finished to be written | ||
| await new Promise((r) => setTimeout(r, 3000)); |
There was a problem hiding this comment.
wait a little for file to finish writing before reading it.
anthogez
reviewed
Feb 23, 2021
anthogez
reviewed
Feb 23, 2021
anthogez
reviewed
Feb 23, 2021
anthogez
reviewed
Feb 23, 2021
lili2311
commented
Feb 23, 2021
lili2311
force-pushed
the
test/improve-flaky-tests
branch
3 times, most recently
from
2f53943
to
af14787
Compare
anthogez
reviewed
Feb 23, 2021
lili2311
force-pushed
the
test/improve-flaky-tests
branch
2 times, most recently
from
293511b
to
143fab7
Compare
lili2311
commented
Feb 24, 2021
test/cli-json-file-output.spec.ts
Outdated
| .toLowerCase() | ||
| .indexOf('windows') === 0; | ||
| describe('test --json-file-output ', () => { | ||
| const noVulnsProjectPath = join(__dirname, '/acceptance', 'workspaces', 'no-vulns'); |
There was a problem hiding this comment.
use a project with no vulns so we are not trying to traverse node_modules for this test which is slow
lili2311
force-pushed
the
test/improve-flaky-tests
branch
2 times, most recently
from
9bf1fa0
to
2c5e30c
Compare
anthogez
reviewed
Feb 24, 2021
lili2311
force-pushed
the
test/improve-flaky-tests
branch
8 times, most recently
from
8d60af3
to
a4dcbad
Compare
anthogez
approved these changes
Feb 25, 2021
lili2311
force-pushed
the
test/improve-flaky-tests
branch
from
a4dcbad
to
b748b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Convert some flaky tests to jest from tap
Increase timeout for analytics tests
Use a smaller fixture with a lockfile for a slow test
test/monitor-target.spec.tsthat was running onnode_modules