Validate binary release checksums #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxjeffos
force-pushed
the
chore/verify-binary-release-checksums
branch
from
f23827c
to
9a43625
Compare
maxjeffos
commented
Feb 4, 2021
| @@ -307,6 +307,11 @@ jobs: | |||
| ls -la ./binary-releases | |||
| - store_artifacts: | |||
| path: ./binary-releases | |||
| - run: | |||
There was a problem hiding this comment.
I think it makes sense to validate the checksums after storing the artifacts (in CCI) so that we can investigate the generated artifacts to understand what went wrong if the do not validate ok.
maxjeffos
force-pushed
the
chore/verify-binary-release-checksums
branch
from
9a43625
to
8b17cb7
Compare
JackuB
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Validates the computed checksums for the binary releases and fail build if they are not ok.
Any background context you want to provide?
https://snyk.slack.com/archives/CH6616JU8/p1612466243049700
What are the relevant tickets?
ZD 8834, 8836