fix: generate sha256 with correct path #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Expected release notes (by @andremidea) fixes:
|
maxjeffos
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
Thanks @andremidea looks good. I checked the generated SHAs here: https://app.circleci.com/pipelines/github/snyk/snyk/3519/workflows/ba9d364a-727c-450b-98dd-5bba0a4e516d/jobs/19705/artifacts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It changes the directory to
binary-releasesbefore generating a sha256, so that it has the correct file name to be verified.This regression was introduced with this change #1564, which caused the
sha256file to be generated withf9245dbba7ccd1e8d4b5eebc7885f445a9af465fc6ef68cc89afa4964575ee36 binary-releases/snyk-macoswhere the file path should besnyk-macos.With this change, it will generate without the
binary-releasesprefix.