feat: update reachability level from "no info" to "no path found" #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Expected release notes (by @darmalovan) features: fixes: others (will not be included in Semantic-Release notes):
|
|
Going to be merged tomorrow (10.2) |
JackuB
approved these changes
Feb 10, 2021
| @@ -130,6 +130,16 @@ Below are flags that are influencing CLI behavior for specific projects, languag | |||
|
|
|||
| - `--configuration-attributes`=<ATTRIBUTE>[,<ATTRIBUTE>]...: | |||
| Select certain values of configuration attributes to resolve the dependencies. E.g. `buildtype:release,usage:java-runtime` | |||
|
|
|||
| - `--reachable`: | |||
There was a problem hiding this comment.
Is this really only for gradle?
There was a problem hiding this comment.
And maven (it's already there for maven)
This was referenced Apr 27, 2023
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some small improvements around reachability:
--reachableflag.Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
https://snyksec.atlassian.net/browse/FLOW-613
https://snyksec.atlassian.net/browse/FLOW-589
Screenshots
Additional questions