Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check jobs’ success instead of workflow #1567

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

Avishagp
Copy link
Contributor

What does this PR do?

Check latest 2 smoke tests' jobs. If the same jobs failed 2 times in a row, try to re-run the latest smoke test and check the job's conclusion.

Any background context you want to provide?

This ensures CLI alerts become less chatty and more focused on urgent problems Hammer should take care of.

@Avishagp Avishagp requested review from a team as code owners December 15, 2020 10:07
@ghost ghost requested review from anthogez and orsagie December 15, 2020 10:07
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2020

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against d143567

Copy link
Contributor

@JackuB JackuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, approving

test/cli-alert/src/index.ts Outdated Show resolved Hide resolved
test/cli-alert/src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@maxjeffos maxjeffos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe a silly question, but how do we know any of this works?

@Avishagp Avishagp merged commit c19278f into master Dec 16, 2020
@Avishagp Avishagp deleted the chore/cli-alert-improvement branch December 16, 2020 14:18
@snyksec
Copy link

snyksec commented Dec 16, 2020

🎉 This PR is included in version 1.437.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants