Resolve type annotation changes required to enable composite in tsconfig
#1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxjeffos
force-pushed
the
spike/declaration-ready
branch
5 times, most recently
from
97cf4e3
to
d09fbe4
Compare
maxjeffos
changed the title
composite in tsconfig
ghost
requested review from
maxjeffos
force-pushed
the
spike/declaration-ready
branch
from
d09fbe4
to
b42bb0d
Compare
orsagie
reviewed
Dec 15, 2020
src/lib/analytics.ts
Outdated
| @@ -82,7 +94,8 @@ function postAnalytics(data) { | |||
|
|
|||
| const headers = {}; | |||
| if (snyk.api) { | |||
| headers.authorization = 'token ' + snyk.api; | |||
| // headers.authorization = 'token ' + snyk.api; | |||
There was a problem hiding this comment.
Any reason for this comment to be here?
There was a problem hiding this comment.
Nope, I'll remove it. Thanks!
maxjeffos
force-pushed
the
spike/declaration-ready
branch
from
b42bb0d
to
714ba35
Compare
|
Expected release notes (by @maxjeffos) fixes:
|
JackuB
approved these changes
Dec 15, 2020
|
🎉 This PR is included in version 1.437.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes some typing issues that are needed for the upcoming modular CLI init PR (#1564).
Any background context you want to provide?
For the modular CLI init / monorepo PR, we will be turning on
"composite": truein the tsconfig which requires certain typing things be addressed beforehand.Why not just do this as part of the aforementioned PR (#1564)? Because that PR is going to touch a lot of things and I would prefer to keep that PR as small as reasonably possible and since this is just about improving some typing (and refactoring analytics into TypeScript) I think it is best kept on its own.
What are the relevant tickets?
HAMMER-237