feat: monitor cpp projects #1520
Conversation
anthogez
force-pushed
the
feat/monitor-cpp-projects
branch
2 times, most recently
from
4386715
to
68a2400
Compare
| @@ -8,7 +8,7 @@ export async function getExtraProjectCount( | |||
| options: Options, | |||
| inspectResult: pluginApi.InspectResult, | |||
| ): Promise<number | undefined> { | |||
| if (options.docker) { | |||
| if (options.docker || options.source) { | |||
There was a problem hiding this comment.
I think I will add a test also for getExtraProjectCount it's not being tested at all
There was a problem hiding this comment.
✅ added for this functionality
anthogez
force-pushed
the
feat/monitor-cpp-projects
branch
from
68a2400
to
9362bbb
Compare
| @@ -5,7 +5,7 @@ import { Ecosystem, EcosystemPlugin } from './types'; | |||
| const EcosystemPlugins: { | |||
| readonly [ecosystem in Ecosystem]: EcosystemPlugin; | |||
| } = { | |||
| cpp: cppPlugin, | |||
| cpp: cppPlugin as EcosystemPlugin, | |||
There was a problem hiding this comment.
I have added this cast in order to avoid TS crying on ScanResult types - cpp-plugin expect only GitTarget while CLI an union of GitTarget | ContainerTarget.
To be honest I do not like this casting neither the as any below - we need decide how do we want proceed here also keep plugins in sync with EcosystemPlugin interface I believe worth move it to its own lib
anthogez
force-pushed
the
feat/monitor-cpp-projects
branch
2 times, most recently
from
29cafe8
to
68da62c
Compare
ghost
requested review from
test/ecosystems.spec.ts
Outdated
| name: 'snyk', | ||
| target: { | ||
| branch: 'feat/monitor-cpp-projects', | ||
| remoteUrl: 'git@github.com:snyk/snyk.git', |
There was a problem hiding this comment.
we need to relax this assertion - so that it still works when we merge to master!
anthogez
force-pushed
the
feat/monitor-cpp-projects
branch
from
68da62c
to
63f9977
Compare
anthogez
force-pushed
the
feat/monitor-cpp-projects
branch
4 times, most recently
from
f88292f
to
90d7962
Compare
| @@ -0,0 +1,207 @@ | |||
| import * as fs from 'fs'; | |||
There was a problem hiding this comment.
Once the number of ecosystems increases we can create a sub-folder foreach
anthogez
force-pushed
the
feat/monitor-cpp-projects
branch
2 times, most recently
from
3b4fbad
to
ee26d57
Compare
anthogez
force-pushed
the
feat/monitor-cpp-projects
branch
from
ee26d57
to
3a91100
Compare
|
🎉 This PR is included in version 1.426.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Monitor C/C++ projects
Using new release of snyk-cpp-plugin that adds target and project name. Sending C/C++ fingerprints to Snyk to be saved as a project and monitored over time.