Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add czech language to snyk woof #1414

Merged
merged 2 commits into from
Sep 16, 2020
Merged

chore: add czech language to snyk woof #1414

merged 2 commits into from
Sep 16, 2020

Conversation

miiila
Copy link
Contributor

@miiila miiila commented Sep 15, 2020

https://www.omniglot.com/language/animalsounds/dogs.htm

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Adds another language spoken to woof command.

@miiila miiila requested review from a team as code owners September 15, 2020 14:24
@miiila miiila self-assigned this Sep 15, 2020
@ghost ghost requested review from admons and dkontorovskyy September 15, 2020 14:24
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2020

Warnings
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?
Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 45fb77b

@@ -9,6 +9,7 @@ const woofs = {
he: ' !הב ',
ru: ' Гав!',
es: 'Guau!',
cs: 'Haf!',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to add a leading space like the "ru" and "he" ones, so that it positions it correctly in the ASCII art 😛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanstanev Should we fix en and es too? 😏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of characters remains consistent I believe english and spanish already show up correctly

@miiila miiila merged commit 8377289 into master Sep 16, 2020
@miiila miiila deleted the chore/czech-woof branch September 16, 2020 09:11
@snyksec
Copy link

snyksec commented Sep 16, 2020

🎉 This PR is included in version 1.398.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants