Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cli dev count use no merge in git log #1408

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

maxjeffos
Copy link
Contributor

@maxjeffos maxjeffos commented Sep 14, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • adds --no-merges to the git log analysis for CLI Dev Count
  • renames the dev-count-analysis test to dev-count-analysis.test.ts so it will be matched in the test:test command

Any background context you want to provide?

Ignore merge commits to try to further de-dupe dev counts and improve accuracy of dev count feature.

@maxjeffos maxjeffos requested review from a team as code owners September 14, 2020 19:13
@ghost ghost requested review from gitphill and orsagie September 14, 2020 19:13
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2020

Expected release notes (by @maxjeffos)

fixes:
ignore merge commits in git log (5a1699a)

others (will not be included in Semantic-Release notes):
rename test file to be included in tests (09646bf)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@maxjeffos maxjeffos merged commit 481ea44 into master Sep 15, 2020
@maxjeffos maxjeffos deleted the fix/cli-dev-count-use-no-merge-in-git-log branch September 15, 2020 13:30
@snyksec
Copy link

snyksec commented Sep 15, 2020

🎉 This PR is included in version 1.397.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants