Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align integration naming for JetBrains IDEs #1392

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

pavel-snyk
Copy link
Contributor

@pavel-snyk pavel-snyk commented Sep 8, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Use JETBRAINS_IDE as integration name for all IntelliJ based IDEs from JetBrains.

@pavel-snyk pavel-snyk requested review from a team as code owners September 8, 2020 15:21
@ghost ghost requested review from MegaBean and orsagie September 8, 2020 15:21
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2020

Expected release notes (by @pavel-snyk)

fixes:
align integration naming for JetBrains IDEs (8d680ec)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2020

Warnings
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 8d680ec

Copy link
Contributor

@maxjeffos maxjeffos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! INTELLIJ is not currently in use so safe to change it.

@pavel-snyk pavel-snyk merged commit 9668ed1 into master Sep 8, 2020
@pavel-snyk pavel-snyk deleted the fix/align-integration-name-for-jetbrains-ide branch September 8, 2020 15:49
@snyksec
Copy link

snyksec commented Sep 8, 2020

🎉 This PR is included in version 1.392.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants