Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mvnw incorrect execution path #1391

Merged
merged 1 commit into from
Sep 7, 2020
Merged

fix: mvnw incorrect execution path #1391

merged 1 commit into from
Sep 7, 2020

Conversation

aviadhahami
Copy link
Contributor

@aviadhahami aviadhahami commented Sep 7, 2020 •
edited

  • Ready for review

What does this PR do?

introduces snyk/snyk-mvn-plugin#84 to the cli

@aviadhahami aviadhahami requested review from a team as code owners September 7, 2020 16:29
@ghost ghost requested review from anthogez and gitphill September 7, 2020 16:29
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2020 •
edited by aviadhahami

Expected release notes (by @aviadhahami)

fixes:
mvnw incorrect execution path (6914f77)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@aviadhahami aviadhahami changed the title fix: upgrade snyk-mvn-plugin to handle mvnw execution fix: mvnw incorrect execution path Sep 7, 2020
dkontorovskyy
dkontorovskyy approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Perfect To Me :)

@aviadhahami aviadhahami merged commit dae8ade into master Sep 7, 2020
@aviadhahami aviadhahami deleted the fix/snyk-mvn-plugin branch September 7, 2020 17:07
@snyksec
Copy link

snyksec commented Sep 7, 2020

🎉 This PR is included in version 1.391.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkontorovskyy dkontorovskyy dkontorovskyy approved these changes

@anthogez anthogez Awaiting requested review from anthogez

@gitphill gitphill Awaiting requested review from gitphill

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
3 participants
@aviadhahami @snyksec @dkontorovskyy