Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve snyk source test display #1390

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

gitphill
Copy link
Contributor

@gitphill gitphill commented Sep 7, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Add color and improve how test results are displayed when running 'snyk
source test' for C/C++ projects.
Add spinner test to give more feedback to user as we test dependencies.
Remove type from ScanResult interface.

@gitphill gitphill requested review from a team as code owners September 7, 2020 14:25
@gitphill gitphill self-assigned this Sep 7, 2020
@ghost ghost requested review from ekbsnyk and orsagie September 7, 2020 14:25
@gitphill gitphill force-pushed the feat/improve-source-test-display branch 2 times, most recently from 80e8374 to 7430314 Compare September 8, 2020 08:52
Add color and improve how test results are displayed when running 'snyk
source test' for C/C++ projects.
Add spinner test to give more feedback to user as we test dependencies.
Remove type from ScanResult interface.
@gitphill gitphill force-pushed the feat/improve-source-test-display branch from 7430314 to 3796530 Compare September 8, 2020 08:53
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2020

Expected release notes (by @gitphill)

features:
improve snyk source test display (3796530)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@gitphill gitphill merged commit 2907db7 into master Sep 8, 2020
@gitphill gitphill deleted the feat/improve-source-test-display branch September 8, 2020 13:21
@snyksec
Copy link

snyksec commented Sep 8, 2020

🎉 This PR is included in version 1.392.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants