feat: remove yarn2 support #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
orsagie
force-pushed
the
feat/remove-yarn-2-support-to-reenable-node-8
branch
2 times, most recently
from
c33dbf8
to
1d4a908
Compare
Yarn2 requires node>10. We still have users on node8 using yarn and ever since we added yarn2 they are no longer able to add snyk to their projects. Since snyk still supports node8, we must unfortunately remove our support for yarn2. Node8 support will be dropped in the near future, after which we can reinstate yarn2 support. In the meantime, users can pin the version 1.387.0 to retain yarn 2 support
orsagie
force-pushed
the
feat/remove-yarn-2-support-to-reenable-node-8
branch
from
1d4a908
to
210408e
Compare
aviadhahami
approved these changes
Sep 6, 2020
JackuB
approved these changes
Sep 7, 2020
Merged
|
🎉 This PR is included in version 1.390.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Yarn2 requires node>10. We still have users on node8 using yarn and ever since we added yarn2 they are no longer able to add snyk to their projects.
Since snyk still supports node8, we must unfortunately remove our support for yarn2.
Node8 support will be dropped in the near future, after which we can reinstate yarn2 support.
In the meantime, users can pin the version 1.387.0 to retain yarn 2 support
See relevant issue: snyk/snyk#1270