Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to disable env expanding in plugin-dotenv #3675

Merged
merged 1 commit into from Aug 24, 2021

Conversation

tudddorrr
Copy link
Contributor

@tudddorrr tudddorrr commented Aug 22, 2021

Changes

Changed the dotenv-expand functionality to be configurable via an expand option (defaults to true). Sometimes you don't want env expansion if you want to run something like envsubst on your built files.

Testing

Added a new expandable variable and snapshot tests for when the option is on/off.

Docs

Yes, added expand option to config table.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2021

🦋 Changeset detected

Latest commit: 3281a0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@snowpack/plugin-dotenv Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/9vY27MagtwMr7pxCDR8dhdoGRH3s
✅ Preview: https://snowpack-git-fork-tudddorrr-main-pikapkg.vercel.app

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is a great feature.

If it’s all right with you, though, this is technically breaking behavior so I’ll treat this as a major change. But other than that, LGTM! Nice tests, too.

@drwpow drwpow merged commit cf1bd44 into FredKSchott:main Aug 24, 2021
@drwpow
Copy link
Collaborator

drwpow commented Aug 24, 2021

Actually, nevermind; I see that you added the option with a default of true so this is indeed minor. Will keep as-is!

@tudddorrr
Copy link
Contributor Author

Thanks @drwpow !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants