Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer /api/ string replace regex #3655

Merged
merged 1 commit into from Aug 24, 2021
Merged

Conversation

siakaramalegos
Copy link
Contributor

Changes

Edits the example proxy api route to show a better regex.

  • The current docs have an invalid regex, though the docfile had a corrected one
  • That corrected one would still replace /apigldjg routes though
  • The new regex only replaces /api/ at the beginning of the string with /

Testing

The regex was tested on the console?

Docs

This is only a change to the docs for a better example.

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2021

⚠️ No Changeset found

Latest commit: 96b0d6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/3HFkexgPdAVnwZhBarjUXdbYLBq8
✅ Preview: https://snowpack-git-fork-siakaramalegos-patch-1-pikapkg.vercel.app

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This change is safer, agreed.

@drwpow drwpow merged commit 6f4698a into FredKSchott:main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants