Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous script language attribute #3548

Merged
merged 1 commit into from Jul 8, 2021
Merged

Remove superfluous script language attribute #3548

merged 1 commit into from Jul 8, 2021

Conversation

sanmai-NL
Copy link
Contributor

Changes

Removes superfluous script language attribute. Rely on the default. This also fixes the respective W3C validator warning.

Testing

The change was not tested locally. Tests weren‘t added. Test code was updated.

Docs

Internal source code quality improvement only.

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2021

⚠️ No Changeset found

Latest commit: fab56b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/Hy1QCqQgamHLysQwhRFFBNi5xJP9
✅ Preview: https://snowpack-git-fork-sanmai-nl-remove-superfluous-s-144bbd-pikapkg.vercel.app

@matthewp
Copy link
Contributor

matthewp commented Jul 7, 2021

+1 for me, but want @drwpow to take a look too.

@drwpow
Copy link
Collaborator

drwpow commented Jul 8, 2021

I’m fine with this, especially for dev.

@drwpow drwpow merged commit 078b776 into FredKSchott:main Jul 8, 2021
drwpow added a commit that referenced this pull request Jul 8, 2021
drwpow added a commit that referenced this pull request Jul 8, 2021
@sanmai-NL
Copy link
Contributor Author

sanmai-NL commented Jul 9, 2021

@drwpow: Why especially?

@sanmai-NL sanmai-NL deleted the Remove-superfluous-script-language-attribute branch July 9, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants