Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing quote #3514

Merged
merged 1 commit into from Jun 30, 2021
Merged

Added missing quote #3514

merged 1 commit into from Jun 30, 2021

Conversation

Beyarz
Copy link
Contributor

@Beyarz Beyarz commented Jun 30, 2021 •
edited

Changes

Added missing quote

Testing

Docs

@vercel
Copy link

vercel bot commented Jun 30, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/2tKc7Ui46omo3FsNynWG2Cb32wbx
✅ Preview: https://snowpack-git-fork-beyarz-patch-1-pikapkg.vercel.app

drwpow
drwpow approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drwpow drwpow merged commit c24e453 into FredKSchott:main Jun 30, 2021
@drwpow
Copy link
Collaborator

drwpow commented Jun 30, 2021

Well unfortunately, it looks like Prettier wants that quote to stay missing. Which makes sense, because react doesn’t need quotes.

Sorry about that! And on your first PR, too 🥳.

I think let’s leave the quote out here, but hopefully you’ll keep submitting more docs fixes! They are all much appreciated.

@Beyarz Beyarz deleted the patch-1 branch June 30, 2021 21:18
@Beyarz
Copy link
Contributor Author

Beyarz commented Jun 30, 2021

Well unfortunately, it looks like Prettier wants that quote to stay missing. Which makes sense, because react doesn’t need quotes.

Sorry about that! And on your first PR, too 🥳.

I think let’s leave the quote out here, but hopefully you’ll keep submitting more docs fixes! They are all much appreciated.

I thought the quotes was missing since Preact had quotes when referring to snowpacks config file.
https://preactjs.com/guide/v10/getting-started/#aliasing-in-snowpack

But I guess either way doesn't matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwpow drwpow drwpow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Beyarz @drwpow